WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
247745
Setting -webkit-column-count to auto is the same as not setting it.
https://bugs.webkit.org/show_bug.cgi?id=247745
Summary
Setting -webkit-column-count to auto is the same as not setting it.
Ahmad Saleem
Reported
2022-11-10 09:51:06 PST
Hi Team, I tried to look for similar bug but couldn't find and it is again based of another Blink commit: Blink Commit -
https://chromium.googlesource.com/chromium/blink/+/da85d1a90375fe50a92cf46f8a49571850618294
Webkit GitHub Source -
https://github.com/WebKit/WebKit/blob/fa2a14f12031baf24d5bc6d6727c3e25c5052589/Source/WebCore/rendering/style/RenderStyle.h#L1282
Test Case (Can't test) -
https://jsfiddle.net/L35709ro/
Because it gives error - "There's no web exposed API usable for this test. The bug doesn't affect layout in a reliable way. Please rerun inside the layout test framework." I am happy to do PR and fix it but would appreciate input of others. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2022-11-11 03:47:33 PST
I think the problem with this merge is that the test cases use internal APIs which are not present in Webkit. I tried it here:
https://github.com/WebKit/WebKit/pull/6368
FAIL internals.updateStyleAndReturnAffectedElementCount() should be 1. Threw exception TypeError: internals.updateStyleAndReturnAffectedElementCount is not a function. (In 'internals.updateStyleAndReturnAffectedElementCount()', 'internals.updateStyleAndReturnAffectedElementCount' is undefined) FAIL internals.needsLayoutCount() should be 0. Threw exception TypeError: internals.needsLayoutCount is not a function. (In 'internals.needsLayoutCount()', 'internals.needsLayoutCount' is undefined) ____ Any solution would be appreciated. Thanks!
Ahmad Saleem
Comment 2
2022-11-11 15:06:51 PST
Close my PR with following comment: "I have to close this bug because Webkit does not support "-webkit-columns: auto " properly and also don't have related Internals Webkit Testing Framework API to land this as it is. I have added first parsing bug as "See Also" while also explained the internal testing framework thing on the bug for future reference. Closing this now." If we can land this without test case then it is good to go. Thanks!
EWS
Comment 3
2022-11-12 11:34:13 PST
Committed
256607@main
(bc1d0765c50f): <
https://commits.webkit.org/256607@main
> Reviewed commits have been landed. Closing PR #6368 and removing active labels.
Radar WebKit Bug Importer
Comment 4
2022-11-12 11:35:18 PST
<
rdar://problem/102278097
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug