Bug 24770 - Geolocation Coordinates do not return null when they should
Summary: Geolocation Coordinates do not return null when they should
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Greg Bolsinga
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-03-23 19:33 PDT by Greg Bolsinga
Modified: 2009-04-13 10:07 PDT (History)
1 user (show)

See Also:


Attachments
patch channeled by Sam (12.94 KB, patch)
2009-04-12 19:45 PDT, Greg Bolsinga
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Bolsinga 2009-03-23 19:33:26 PDT
See:

http://dev.w3.org/geo/api/spec-source.html#coordinates

The current implementation returns 0 or -1.
Comment 1 Greg Bolsinga 2009-03-23 19:33:52 PDT
<rdar://problem/6713745>
Comment 2 Greg Bolsinga 2009-04-12 19:45:20 PDT
Created attachment 29426 [details]
patch channeled by Sam

This is from the beginnings of a patch from Sam. I've added it to support the 4 Coordinates properties that are null if they cannot be provided.
Comment 3 Darin Adler 2009-04-13 07:46:07 PDT
Comment on attachment 29426 [details]
patch channeled by Sam

Seems to me that since these are doubles we could have used NaN instead of separate booleans to initialize the Coordinates object.

r=me
Comment 4 Greg Bolsinga 2009-04-13 10:07:54 PDT
bolsinga:WebKit bolsinga$ svn commit
Sending        WebCore/ChangeLog
Sending        WebCore/GNUmakefile.am
Sending        WebCore/WebCore.pro
Sending        WebCore/WebCore.scons
Sending        WebCore/WebCore.vcproj/WebCore.vcproj
Sending        WebCore/WebCore.xcodeproj/project.pbxproj
Sending        WebCore/WebCoreSources.bkl
Adding         WebCore/bindings/js/JSCoordinatesCustom.cpp
Sending        WebCore/page/Coordinates.h
Sending        WebCore/page/Coordinates.idl
Sending        WebCore/platform/mac/GeolocationServiceMac.mm
Transmitting file data ...........
Committed revision 42437.