CLOSED WONTFIX 24767
reduce number of calls to String::append in V8LazyEventListener 
https://bugs.webkit.org/show_bug.cgi?id=24767
Summary reduce number of calls to String::append in V8LazyEventListener
Antony Sargent
Reported 2009-03-23 16:22:00 PDT
These are surprisingly expensive. Patch forthcoming.
Attachments
patch (2.51 KB, patch)
2009-03-23 16:23 PDT, Antony Sargent 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antony Sargent
Comment 1 2009-03-23 16:23:59 PDT
Created attachment 28873 [details] patch
Antony Sargent
Comment 2 2009-03-23 16:27:53 PDT
Now that I review the patch, I notice that Mike already committed a similar fix. So nevermind, please close.
Eric Seidel (no email)
Comment 3 2009-03-26 11:41:41 PDT
Comment on attachment 28873 [details] patch Is this the proper multi-line string syntax? i.e. why were there \ before but not now? We have a String::printf I think, wouldn't that be more efficient than this 3 appends? You might actually want to use StringBuilder here instead, or just a Vector<UChar> Also, this should be "const char*" in WebKit style.
Note You need to log in before you can comment on or make changes to this bug.