Bug 24767 - reduce number of calls to String::append in V8LazyEventListener
Summary: reduce number of calls to String::append in V8LazyEventListener
Status: CLOSED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-23 16:22 PDT by Antony Sargent
Modified: 2009-03-26 11:41 PDT (History)
0 users

See Also:

Attachments
patch (2.51 KB, patch)
2009-03-23 16:23 PDT, Antony Sargent 		eric: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antony Sargent 2009-03-23 16:22:00 PDT 
These are surprisingly expensive. 

Patch forthcoming.
Comment 1 Antony Sargent 2009-03-23 16:23:59 PDT 
Created attachment 28873 [details]
patch
Comment 2 Antony Sargent 2009-03-23 16:27:53 PDT 
Now that I review the patch, I notice that Mike already committed a similar fix. So nevermind, please close.
Comment 3 Eric Seidel (no email) 2009-03-26 11:41:41 PDT 
Comment on attachment 28873 [details]
patch

Is this the proper multi-line string syntax?   i.e. why were there \ before but not now?

We have a String::printf I think, wouldn't that be more efficient than this 3 appends?  You might actually want to use StringBuilder here instead, or just a Vector<UChar>

Also, this should be "const char*" in WebKit style.