Bug 24765 - prepare-ChangeLog and svn-create-patch doesn't work with svn 1.6
Summary: prepare-ChangeLog and svn-create-patch doesn't work with svn 1.6
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-23 14:15 PDT by Anders Carlsson
Modified: 2009-03-29 16:09 PDT (History)
3 users (show)

See Also:


Attachments
"Fix" (1.07 KB, patch)
2009-03-23 14:20 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
svn 1.6-only patch (1.25 KB, patch)
2009-03-23 14:21 PDT, mitz
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2009-03-23 14:15:46 PDT
andersca1:WebKit andersca$ svn-create-patch 
svn: ' mac/Misc' is not a working copy
svn: ' mac/Misc' does not exist
svn: ' mac/Misc/WebKit.h' is not a working copy
svn: ' mac/Misc/WebKit.h' does not exist
andersca1:WebKit andersca$ pwd
/Users/andersca/WebKit/OpenSource/WebKit

Looks like an extra space was introduced somewhere in svn 1.6
Comment 1 Anders Carlsson 2009-03-23 14:16:59 PDT
andersca1:WebKit andersca$ svn diff
Index: mac/Misc/WebKit.h
===================================================================
--- mac/Misc/WebKit.h	(revision 41917)
+++ mac/Misc/WebKit.h	(working copy)
@@ -50,3 +50,4 @@
 #import <WebKit/WebScriptObject.h>
 #import <WebKit/WebUIDelegate.h>
 #import <WebKit/WebView.h>
+

is the "patch" 
Comment 2 mitz 2009-03-23 14:17:55 PDT
There's an additional status column in "svn status" output in svn 1.6.
Comment 3 Anders Carlsson 2009-03-23 14:20:56 PDT
Created attachment 28867 [details]
"Fix"

This fix makes it work with 1.6 only.
Comment 4 mitz 2009-03-23 14:21:07 PDT
Created attachment 28868 [details]
svn 1.6-only patch

These changes make the scripts work with svn 1.6 but break them for svn 1.5 and earlier
Comment 5 David Kilzer (:ddkilzer) 2009-03-29 16:08:45 PDT
Apparently this was fixed in r42053.

http://trac.webkit.org/changeset/42053
Comment 6 David Kilzer (:ddkilzer) 2009-03-29 16:09:24 PDT
Maybe we can post the patch next time?