WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
247646
onorientationchange and orientation attributes must be present unconditionally even on platforms without orientation change
https://bugs.webkit.org/show_bug.cgi?id=247646
Summary
onorientationchange and orientation attributes must be present unconditionall...
Darin Adler
Reported
2022-11-08 14:42:26 PST
https://compat.spec.whatwg.org/#windoworientation-interface
Our implementation is only on platforms with an orientation concept, but the specification says it should be everywhere. That is straightforward to do.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-11-08 14:44:18 PST
<
rdar://problem/102110117
>
Darin Adler
Comment 2
2022-11-08 14:55:34 PST
Pull request:
https://github.com/WebKit/WebKit/pull/6269
EWS
Comment 3
2022-11-08 17:00:33 PST
Committed
256469@main
(052d5b6a2ca0): <
https://commits.webkit.org/256469@main
> Reviewed commits have been landed. Closing PR #6269 and removing active labels.
Chris Dumez
Comment 4
2023-03-06 07:31:37 PST
The spec (
https://compat.spec.whatwg.org/#windoworientation-interface
) says: "User agents implementing the window.orientation attribute and its associated orientationchange event must not expose them on non-Mobile platforms." Firefox and Chrome both don't expose this on Desktop. We have evidence of site breakage from this (
rdar://106273441
). I think we should revert.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug