Bug 247460 - JetStream driver should ignore references to URL parameters when run in `jsc` shell
Summary: JetStream driver should ignore references to URL parameters when run in `jsc`...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P1 Major
Assignee: hysu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-03 15:47 PDT by hysu
Modified: 2022-11-03 17:58 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hysu 2022-11-03 15:47:54 PDT 
https://bugs.webkit.org/show_bug.cgi?id=247301 broke JS2 testing on Linux, as well as RAMification on macOS.
The cause for this is that `URLSearchParams` is undefined in the `jsc` shell. When run in the shell, URL parameters are irrelevant anyways (because the test is not being invoked via a URL), so ideally this logic should be ignored.

```
$ ~/tools/WebKit/WebKitBuild/Release/bin/jsc watch-cli.js 
Exception: ReferenceError: Can't find variable: URLSearchParams
```
Comment 1 Radar WebKit Bug Importer 2022-11-03 15:48:20 PDT 
<rdar://problem/101934826>
Comment 2 hysu 2022-11-03 16:13:03 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/6109
Comment 3 EWS 2022-11-03 17:58:10 PDT 
Committed 256304@main (e43d0d6df748): <https://commits.webkit.org/256304@main>

Reviewed commits have been landed. Closing PR #6109 and removing active labels.