WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
24737
[Qt] QAction's aren't created / returned for InsertParagraphSeparator and InsertLineSeparator.
https://bugs.webkit.org/show_bug.cgi?id=24737
Summary
[Qt] QAction's aren't created / returned for InsertParagraphSeparator and Ins...
Erik L. Bunce
Reported
2009-03-20 23:20:11 PDT
QWebPage::action() should create and return a QAction object for each QWebPage WebAction. Currently neither InsertParagraphSeparator nor InsertLineSeparator do so.
Attachments
Fix to make QWebPage::action() return and update InsertParagraphSeparator and InsertLineSeparator.
(3.34 KB, patch)
2009-03-20 23:25 PDT
,
Erik L. Bunce
hausmann
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Erik L. Bunce
Comment 1
2009-03-20 23:25:53 PDT
Created
attachment 28819
[details]
Fix to make QWebPage::action() return and update InsertParagraphSeparator and InsertLineSeparator.
Simon Hausmann
Comment 2
2009-03-26 02:11:13 PDT
Comment on
attachment 28819
[details]
Fix to make QWebPage::action() return and update InsertParagraphSeparator and InsertLineSeparator. Looks good to me. Only the indentation in the ChangeLog needs to be fixed when landing :)
Ariya Hidayat
Comment 3
2009-03-26 04:48:35 PDT
Landed in
r42000
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug