WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
247365
[Content Extensions] QueryTransforms should not unconditionally redirect to form-encoded URLs
https://bugs.webkit.org/show_bug.cgi?id=247365
Summary
[Content Extensions] QueryTransforms should not unconditionally redirect to f...
Wenson Hsieh
Reported
2022-11-02 08:49:40 PDT
Currently, anything that passes through `RedirectAction::URLTransformAction::QueryTransform::applyToURL` gets unconditionally form-encoded (e.g. "=" -> "%20"), regardless of whether any rules actually matched. This is because we always transform the query through `URLParser::parseURLEncodedForm`, and set the transformed URL query to the result, even if no parameters were removed/replaced/added. For both performance and correctness, it probably makes sense to allow query parameters to pass through in their original form, if no rules matched.
Attachments
Add attachment
proposed patch, testcase, etc.
Wenson Hsieh
Comment 1
2022-11-02 12:53:19 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/6045
EWS
Comment 2
2022-11-02 17:15:58 PDT
Committed
256260@main
(b60c1a321a03): <
https://commits.webkit.org/256260@main
> Reviewed commits have been landed. Closing PR #6045 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2022-11-02 17:19:12 PDT
<
rdar://problem/101887185
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug