Bug 247295 - WebPermissionControllerProxy::Query message reply should go to correct completion handler
Summary: WebPermissionControllerProxy::Query message reply should go to correct comple...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-31 15:44 PDT by Alex Christensen
Modified: 2022-11-03 16:18 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2022-10-31 15:44:44 PDT 
Before this change, we were just hoping that the requests are responded to in the same order that the queries were sent.  Quite fragile, and when things go wrong sometimes we try to call a null CompletionHandler.  This makes it more robust.
Comment 1 Alex Christensen 2022-10-31 15:45:35 PDT 
<rdar://problem/100894959>
Comment 2 Alex Christensen 2022-10-31 15:46:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5984
Comment 3 EWS 2022-11-03 16:18:26 PDT 
Committed 256298@main (0310eb3e5fd3): <https://commits.webkit.org/256298@main>

Reviewed commits have been landed. Closing PR #5984 and removing active labels.