NEW 247274
We need git-webkit apply-pr and apply-from-bug 
https://bugs.webkit.org/show_bug.cgi?id=247274
Summary We need git-webkit apply-pr and apply-from-bug
Ryosuke Niwa
Reported 2022-10-31 11:32:53 PDT
webkit-patch has apply-attachment and apply-from-bug to apply patches posted on Bugzilla. We need an equivalent command for applying PR and/or PR associated with the bug.
Attachments
Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2022-10-31 11:51:16 PDT
Note that one of important use cases is to apply PR written by someone else.
Alexey Proskuryakov
Comment 2 2022-10-31 11:55:17 PDT
Arguably more important than it was in webkit-patch, because downloading a diff file from GitHub is an undiscoverable action.
Ryosuke Niwa
Comment 3 2022-10-31 11:57:15 PDT
(In reply to Alexey Proskuryakov from comment #2) > Arguably more important than it was in webkit-patch, because downloading a > diff file from GitHub is an undiscoverable action. Yeah, we used to able to download the diff on Bugzilla and apply that locally. Can't do that anymore either.
Alexey Proskuryakov
Comment 4 2022-10-31 13:27:46 PDT
I should have explained how this undiscoverable action works. Adding .diff or .patch to a PR or commit link (like https://github.com/WebKit/WebKit/pull/5969.diff) produces downloadable diffs, either "git diff" or "git patch" style.
Radar WebKit Bug Importer
Comment 5 2022-11-07 10:33:18 PST
<rdar://problem/102048463>
Jonathan Bedard
Comment 6 2023-04-20 08:52:46 PDT
`git-webkit checkout pr-#` exists, and is designed to solve this problem. If we wanted to expand this to bugs, we're basically resolving the pointer to the PR, then checking out the PR.
Note You need to log in before you can comment on or make changes to this bug.