RESOLVED FIXED 24727
Need to upstream V8XMLHttpRequest* 
https://bugs.webkit.org/show_bug.cgi?id=24727
Summary Need to upstream V8XMLHttpRequest*
David Levin
Reported 2009-03-20 14:38:25 PDT
See summary.
Attachments
Proposed fix. (40.07 KB, patch)
2009-03-20 14:40 PDT, David Levin 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-03-20 14:40:16 PDT
Created attachment 28801 [details] Proposed fix.
Dimitri Glazkov (Google)
Comment 2 2009-03-21 20:34:41 PDT
Comment on attachment 28801 [details] Proposed fix. Proper design for all these hidden dependency helpers is out of scope for this scrubbing, so LGTM, good to land after these changes: > + if (ec) { > + V8Proxy::SetDOMException(ec); > + return v8::Handle<v8::Value>(); > + } I have a helper in V8Proxy.h that might be useful here, throwError > + if (ec) { > + V8Proxy::SetDOMException(ec); > + return v8::Handle<v8::Value>(); > + } ... and here. > + if (args.Length() < 2) { > + V8Proxy::ThrowError(V8Proxy::SYNTAX_ERROR, "Not enough arguments"); > + return v8::Undefined(); > + } ... and here. > + if (ec) { > + V8Proxy::SetDOMException(ec); > + return v8::Handle<v8::Value>(); > + } ... and here. > + INC_STATS("DOM.XMLHttpRequest.getResponseHeader()"); > + if (args.Length() < 1) { > + V8Proxy::ThrowError(V8Proxy::SYNTAX_ERROR, "Not enough arguments"); > + return v8::Undefined(); > + } Ditto. > + if (ec) { > + V8Proxy::SetDOMException(ec); > + return v8::Handle<v8::Value>(); > + } > + return v8StringOrNull(result); > +} Same thing. > + if (args.Length() < 1) { > + V8Proxy::ThrowError(V8Proxy::SYNTAX_ERROR, "Not enough arguments"); > + return v8::Undefined(); > + } Analogously.
David Levin
Comment 3 2009-03-22 00:36:31 PDT
Committed as r41898.
Note You need to log in before you can comment on or make changes to this bug.