Bug 247239 - [Live Range Selection] Expanding selection by granularity should expand anchor & focus
Summary: [Live Range Selection] Expanding selection by granularity should expand ancho...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 216325
  Show dependency tree / graph
 
Reported: 2022-10-29 21:51 PDT by Ryosuke Niwa
Modified: 2022-11-23 01:52 PST (History)
6 users (show)

See Also:

Attachments
WIP (3.07 KB, patch)
2022-10-29 21:57 PDT, Ryosuke Niwa 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2022-10-29 21:51:09 PDT 
When expanding selection by non-character granularity, it should also affect anchor & focus.
Comment 1 Ryosuke Niwa 2022-10-29 21:57:18 PDT 
Created attachment 463307 [details]
WIP
Comment 2 Ryosuke Niwa 2022-10-29 22:06:23 PDT 
The last test case in editing/selection/shift-click.html fails with this change. Need to look into that next week.
Comment 3 Radar WebKit Bug Importer 2022-10-29 22:06:45 PDT 
<rdar://problem/101722271>
Comment 4 Ryosuke Niwa 2022-10-30 12:35:50 PDT 
Comment on attachment 463307 [details]
WIP

Oh, this is interesting. The test failure goes away if I restore the old code in
VisibleSelection::validate instead of new code in VisibleSelection::expandUsingGranularity.
Comment 5 Ryosuke Niwa 2022-10-30 14:22:24 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5945
Comment 6 EWS 2022-10-31 16:40:12 PDT 
Committed 256174@main (ca201a717c24): <https://commits.webkit.org/256174@main>

Reviewed commits have been landed. Closing PR #5945 and removing active labels.