RESOLVED FIXED247238
[IFC][Integration] Disable IFC for RenderVTTCue 
https://bugs.webkit.org/show_bug.cgi?id=247238
Summary [IFC][Integration] Disable IFC for RenderVTTCue
alan
Reported 2022-10-29 20:28:43 PDT
ssia
Attachments
[fast-cq]Patch (3.05 KB, patch)
2022-10-29 20:32 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (1.57 KB, patch)
2022-10-30 12:34 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-10-29 20:32:58 PDT
Created attachment 463306 [details] [fast-cq]Patch
Antti Koivisto
Comment 2 2022-10-30 01:24:17 PDT
Comment on attachment 463306 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463306&action=review > COMMIT_MESSAGE:6 > +RenderVTTCue consults with legacy line layout structures directly (it's been disabled through line-box-contain. see mediaControls.css) mediaControls.css is some old leftover that is not used at least on Apple platforms. But I suppose the modern controls ended up disabling it anyway.
EWS
Comment 3 2022-10-30 07:08:15 PDT
Committed 256139@main (ec9adcfcd3db): <https://commits.webkit.org/256139@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463306 [details].
Radar WebKit Bug Importer
Comment 4 2022-10-30 07:09:18 PDT
<rdar://problem/101729043>
alan
Comment 5 2022-10-30 07:09:50 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 463306 [details] > [fast-cq]Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=463306&action=review > > > COMMIT_MESSAGE:6 > > +RenderVTTCue consults with legacy line layout structures directly (it's been disabled through line-box-contain. see mediaControls.css) > > mediaControls.css is some old leftover that is not used at least on Apple > platforms. But I suppose the modern controls ended up disabling it anyway. oh ok, webinpsector shows line-box-contain
alan
Comment 6 2022-10-30 12:33:56 PDT
Reopening to attach new patch.
alan
Comment 7 2022-10-30 12:34:03 PDT
Created attachment 463315 [details] [fast-cq]Patch
EWS
Comment 8 2022-10-30 18:41:48 PDT
Found 1 new test failure: imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html
EWS
Comment 9 2022-10-30 19:12:18 PDT
Committed 256144@main (81ba4136c619): <https://commits.webkit.org/256144@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463315 [details].
Note You need to log in before you can comment on or make changes to this bug.