NEW247230
Fix clientLeft value for RTL direction, while the element have vertical scrollbar in left side.
https://bugs.webkit.org/show_bug.cgi?id=247230
Summary Fix clientLeft value for RTL direction, while the element have vertical scrol...
Ahmad Saleem
Reported 2022-10-29 07:05:29 PDT
Hi Team, Going through Blink Commits and noticed another Interop failure in Webkit / Safari compared to Blink / Chrome and Gecko / Firefox: Failing Test - https://jsfiddle.net/pLhcn1ek/ Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=168625 _____ I am raising this bug because I was not able to find related and wanted to try to do PR and if I fail, I will link my PR to give details on why I am not able to do it. Thanks!
Attachments
Safari vs Other browsers (445.83 KB, image/png)
2023-05-29 16:20 PDT, Ahmad Saleem
no flags
Ahmad Saleem
Comment 1 2022-10-29 14:16:34 PDT
I did PR here and took this test case is failing: https://github.com/WebKit/WebKit/pull/5935 Current Test - failing with PR above - https://jsfiddle.net/pucvsazy/show In current Tests: *** Chrome Canary 109 *** Pass first two and fail last two: Position of square in 'v-rl ltr' - expected 80, got 65 Position of square in 'v-rl rtl' - expected 80, got 65 *** Firefox Nightly 108 *** Pass all tests *** Safari Technology Preview 156 & Safari 16.1 *** Pass all tests _____ Now weird one is Firefox: 1) It passes the failing tests from Comment 0 2) Passes current test as welll. While Safari had 15 px difference in the failing test from Comment 0 and it will might cause us to change expectations for two failing test from 80 to 65 but it is now also failing all four as below: Position of square in 'h-tb rtl' - expected 80, got 95 Position of square in 'h-bt rtl' - expected 80, got 95 Position of square in 'v-rl ltr' - expected 80, got 65 Position of square in 'v-rl rtl' - expected 80, got 65 _____ So it is weird bug IMO.
Ahmad Saleem
Comment 2 2022-10-29 15:23:42 PDT
(In reply to Ahmad Saleem from comment #1) > I did PR here and took this test case is failing: > > https://github.com/WebKit/WebKit/pull/5935 > > Current Test - failing with PR above - https://jsfiddle.net/pucvsazy/show > > In current Tests: > > *** Chrome Canary 109 *** > > Pass first two and fail last two: > > Position of square in 'v-rl ltr' - expected 80, got 65 > Position of square in 'v-rl rtl' - expected 80, got 65 > > *** Firefox Nightly 108 *** > > Pass all tests > > *** Safari Technology Preview 156 & Safari 16.1 *** > > Pass all tests > > _____ > > Now weird one is Firefox: > > 1) It passes the failing tests from Comment 0 > 2) Passes current test as welll. > > While Safari had 15 px difference in the failing test from Comment 0 and it > will might cause us to change expectations for two failing test from 80 to > 65 but it is now also failing all four as below: > > Position of square in 'h-tb rtl' - expected 80, got 95 > Position of square in 'h-bt rtl' - expected 80, got 95 > Position of square in 'v-rl ltr' - expected 80, got 65 > Position of square in 'v-rl rtl' - expected 80, got 65 > > _____ > > So it is weird bug IMO. Due to complexity of change and leading to weird difference from other browsers, I am closing my PR.
Radar WebKit Bug Importer
Comment 3 2022-11-05 07:06:18 PDT
Ahmad Saleem
Comment 4 2023-05-29 16:20:57 PDT
Created attachment 466533 [details] Safari vs Other browsers Just wanted to show the result for: https://jsfiddle.net/pucvsazy/show ^ All browser differ.
Note You need to log in before you can comment on or make changes to this bug.