NEW 247226
[MSVC] constexpr-if statement in ArgumentCoders.h causes compilation errors 
https://bugs.webkit.org/show_bug.cgi?id=247226
Summary [MSVC] constexpr-if statement in ArgumentCoders.h causes compilation errors
Zan Dobersek
Reported 2022-10-29 04:21:47 PDT
After 255496@main a compilation issue was reported on MSVC++: > something.cpp(whatever-line-is-end-of-file): fatal error C1024: unexpected end-of-file found Daniel narrowed this down to the listed change, and also narrowed down the problem to the constexpr-if introduced in the patch: > if constexpr (Index < sizeof...(Elements)) { ... What reportedly does work as intended is moving the calculation of the condition into a separate constexpr variable: > constexpr bool Recurse = (Index < sizeof...(Elements)); :shrug:
Attachments
Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-10-29 04:53:00 PDT
This looks like dup of bug#246506.
Daniel Kolesa
Comment 2 2022-10-29 05:05:35 PDT
looks like a dupe of that, yeah there is actually a second instance of the error as well, introduced with https://github.com/WebKit/WebKit/commit/227096eba1370f2212bbfd7146580392846b1c7d#diff-92c56ce66bb066fa2340e34258930e3f33b5742330cfc3e460426d0df25cee3a
Daniel Kolesa
Comment 3 2022-10-29 05:06:41 PDT
are we interested in working around this in webkit, or just expect everyone to update their compiler?
Fujii Hironori
Comment 4 2022-10-29 05:51:29 PDT
MSVC already fixed the compiler bug. And, all upstream Windows bots are using VS2022. I think the workaround shouldn't be upstream and everyone should update VS.
Daniel Kolesa
Comment 5 2022-10-31 08:16:58 PDT
sgtm, let's do that then
Radar WebKit Bug Importer
Comment 6 2022-11-05 04:22:17 PDT
<rdar://problem/101994278>
Note You need to log in before you can comment on or make changes to this bug.