After 255496@main a compilation issue was reported on MSVC++: > something.cpp(whatever-line-is-end-of-file): fatal error C1024: unexpected end-of-file found Daniel narrowed this down to the listed change, and also narrowed down the problem to the constexpr-if introduced in the patch: > if constexpr (Index < sizeof...(Elements)) { ... What reportedly does work as intended is moving the calculation of the condition into a separate constexpr variable: > constexpr bool Recurse = (Index < sizeof...(Elements)); :shrug:
This looks like dup of bug#246506.
looks like a dupe of that, yeah there is actually a second instance of the error as well, introduced with https://github.com/WebKit/WebKit/commit/227096eba1370f2212bbfd7146580392846b1c7d#diff-92c56ce66bb066fa2340e34258930e3f33b5742330cfc3e460426d0df25cee3a
are we interested in working around this in webkit, or just expect everyone to update their compiler?
MSVC already fixed the compiler bug. And, all upstream Windows bots are using VS2022. I think the workaround shouldn't be upstream and everyone should update VS.
sgtm, let's do that then
<rdar://problem/101994278>