Bug 247210 - [git-webkit] Handle branch names which might be hashes
Summary: [git-webkit] Handle branch names which might be hashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-28 13:40 PDT by Jonathan Bedard
Modified: 2022-11-08 13:07 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-10-28 13:40:31 PDT 
There are a number of branch names that might be confused for hashes. Contributors should, in practice, prefix `eng/` to branches to avoid problems like this, but it's also something we can occasionaly handle in tools code as well.
Comment 1 Radar WebKit Bug Importer 2022-10-28 13:40:48 PDT 
<rdar://problem/101691330>
Comment 2 Jonathan Bedard 2022-10-28 13:43:45 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5920
Comment 3 EWS 2022-11-01 11:51:25 PDT 
Committed 256193@main (7952ec032b23): <https://commits.webkit.org/256193@main>

Reviewed commits have been landed. Closing PR #5920 and removing active labels.
Comment 4 EWS 2022-11-08 13:07:36 PST 
Committed 252432.785@safari-7614-branch (2b7211b50cd9): <https://commits.webkit.org/252432.785@safari-7614-branch>

Reviewed commits have been landed. Closing PR #192 and removing active labels.