Bug 24720 – <input type="range"> invisible in Chromium port

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Peter Kasting]

I need to add appropriate functions to RenderThemeChromiumWin.cpp.

[Peter Kasting]

Created attachment 28790 [details]
patch v1

This patch also does a little reordering in one of the switches to put parts in numerical order.

[Darin Fisher (:fishd, Google)]

Comment on attachment 28790 [details]
patch v1

>Index: WebCore/rendering/RenderThemeChromiumWin.cpp

>+bool RenderThemeChromiumWin::paintSliderTrack(RenderObject* o, const RenderObject::PaintInfo& i, const IntRect& r)
>+{
>+    const ThemeData& themeData = getThemeData(o);
>+
>+    WebCore::ThemePainter painter(i.context, r);
>+    ChromiumBridge::paintTrackbar(painter.context(),

Looks like you forgot to include your changes to ChromiumBridge in this patch.


>     case ListboxPart:
>     case MenulistPart:
>     case SearchFieldPart:
>     case TextFieldPart:
>     case TextAreaPart:
>-        result.m_part = ETS_NORMAL;
>+        result.m_part = EP_EDITTEXT;

what is the reason for this change?

[Peter Kasting]

Sorry, will add ChromiumBridge.h.  (The .cpp file is only in the Chrome tree, it looks like?)

The EP_EDITTEXT change is because ETS_NORMAL is a state, not a part.  EP_EDITTEXT is a part.  They're both defined to 1 under the hood.

[Peter Kasting]

Created attachment 28814 [details]
patch v2

[Peter Kasting]

Fixed in r41915.