RESOLVED FIXED 247149
WebSocket: Allow relative URLs and http(s) scheme 
https://bugs.webkit.org/show_bug.cgi?id=247149
Summary WebSocket: Allow relative URLs and http(s) scheme
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-11-03 13:53:19 PDT
<rdar://problem/101929623>
Alex Christensen
Comment 2 2022-11-04 14:05:47 PDT
This is significantly different than Firefox's approach. I think Anne's comment "If we accept HTTP(S) schemes though we probably first want to normalize them to ws/wss, for the sake of consistency with the existing url getter" is interesting and should be considered. Tests need updating.
me
Comment 3 2022-11-04 14:24:19 PDT
(In reply to Alex Christensen from comment #2) > This is significantly different than Firefox's approach. > > I think Anne's comment "If we accept HTTP(S) schemes though we probably > first want to normalize them to ws/wss, for the sake of consistency with the > existing url getter" is interesting and should be considered. > > Tests need updating. I tested both against the same site and they behaved as expected, although slight deviations may exist? I have a pr against WPT which should help with ensuring things are working as expected. I don't know the exact processes but once that is merged I'll need help rolling wpt so this patch can be tested properly. I thought it made more sense for the url getter to reflect the url that was passed in so it is not normalized. Do you feel strongly that it should be?
Anne van Kesteren
Comment 4 2023-05-11 03:07:30 PDT
Pull request: https://github.com/WebKit/WebKit/pull/13751
EWS
Comment 5 2023-05-11 08:16:05 PDT
Committed 263968@main (b5e7897d6636): <https://commits.webkit.org/263968@main> Reviewed commits have been landed. Closing PR #13751 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.