Bug 247122 – [MSE] Bring back some useful SourceBuffer logs

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Enrique Ocaña]

Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line https://github.com/WebKit/WebKit/commit/cd4e7ebee1a6aaa956534cb8709d95ec2c75b85a#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems.

[Enrique Ocaña]

Pull request: https://github.com/WebKit/WebKit/pull/5854

[EWS]

Committed 256224@main (e5e73c6cc13d): <https://commits.webkit.org/256224@main>

Reviewed commits have been landed. Closing PR #5854 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/101853612>

[Enrique Ocaña]

Jer Noble gave the following feedback in Slack:

This logging change looks pretty bad; there’s no need to use printf(); DEBUG_LOG() works with StringConcatenation. There’s no need to include the method name, because that’s included with LOGIDENTIFIER. And *this shouldn’t be needed here as that’s also included in LOGIDENTIFIER*.

Can you please undo these changes you made? They can be replaced with something more like this:

DEBUG_LOG(LOGIDENTIFIER, "size = ", size, ", buffered = ", m_private->buffered()->ranges());

If you get an error concatenating a PlatformTimeRanges, the right way to deal with that is to add a macro to PlatformTimeRanges.h like the one from MediaTime.h:

template<typename> struct LogArgument;

template<> struct LogArgument<MediaTime> {
    static String toString(const MediaTime& time) { return time.toJSONString(); }
};
template<> struct LogArgument<MediaTimeRange> {
    static String toString(const MediaTimeRange& range) { return range.toJSONString(); }
};

[Enrique Ocaña]

Pull request: https://github.com/WebKit/WebKit/pull/6044

[EWS]

Committed 256317@main (445669890d9b): <https://commits.webkit.org/256317@main>

Reviewed commits have been landed. Closing PR #6044 and removing active labels.