WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
247096
XMLSerializer.serializeToString() should support Attr node as parameter
https://bugs.webkit.org/show_bug.cgi?id=247096
Summary
XMLSerializer.serializeToString() should support Attr node as parameter
Ahmad Saleem
Reported
2022-10-26 15:49:46 PDT
Hi Team, I just came across another bug / testcase, which is failing in Safari 16 / Safari TP 156: Test Case -
https://jsfiddle.net/20no3p91/show
Blink Commit -
https://chromium.googlesource.com/chromium/src.git/+/271184ec08ca181a7d93eed532f3ce9efb9c0bcc
WPT Cover - Nope Gecko - Failing similar to Webkit as of right now. _________ Webkit Source -
https://github.com/WebKit/WebKit/blob/f6f2c95eb900fce4967fbfb6586416363eb4fe7e/Source/WebCore/editing/MarkupAccumulator.cpp#L602
To do: result.appendAttribute(downcast<Attr>(node).value()); or appendAttribute(downcast<Attr>(node).value()); or something else totally. NOTE - Add "Attr.h" header as well. _____ Just wanted to create bug, so if I end up doing PR then I have something or else someone else take it up. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2022-10-28 22:47:31 PDT
Committed
256126@main
(38ce5b803b34): <
https://commits.webkit.org/256126@main
> Reviewed commits have been landed. Closing PR #5835 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2022-10-28 22:48:19 PDT
<
rdar://problem/101705913
>
Anne van Kesteren
Comment 3
2024-03-15 05:39:27 PDT
***
Bug 20250
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug