Bug 247092 - [GTK4] GdkEvent should be managed by GRefPtr, not GUniquePtr
Summary: [GTK4] GdkEvent should be managed by GRefPtr, not GUniquePtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
: 243290 (view as bug list)
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2022-10-26 15:12 PDT by Michael Catanzaro
Modified: 2022-11-14 05:45 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2022-10-26 15:12:48 PDT 
In GTK 3, we use GUniquePtr to manage the lifetime of GdkEvents. But in GTK 4, we should switch to GRefPtr instead, rather than using a GUniquePtr that confusingly "deletes" the GdkEvent with gdk_event_unref().
Comment 1 Michael Catanzaro 2022-10-26 16:31:51 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5831
Comment 2 Michael Catanzaro 2022-11-09 10:23:45 PST 
*** Bug 243290 has been marked as a duplicate of this bug. ***
Comment 3 EWS 2022-11-14 05:45:20 PST 
Committed 256651@main (242c638012dd): <https://commits.webkit.org/256651@main>

Reviewed commits have been landed. Closing PR #5831 and removing active labels.