<rdar://101519984>
Created attachment 463261 [details] Patch
Comment on attachment 463261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463261&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:585 > - if (!lineHasOverflow || isInIntrinsicWidthMode) > + auto lineHasOverflowAfterTrimmingTrailingContent = horizontalAvailableSpace < m_line.contentLogicalWidth(); > + if (!lineHasOverflowAfterTrimmingTrailingContent || isInIntrinsicWidthMode) Maybe this function should be refactored a bit, for example split into before-trimming and after-trimming parts? It is kinda confusing there is a lineHasOverflow variable in the scope that has incorrect value.
(In reply to Antti Koivisto from comment #2) > Comment on attachment 463261 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=463261&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:585 > > - if (!lineHasOverflow || isInIntrinsicWidthMode) > > + auto lineHasOverflowAfterTrimmingTrailingContent = horizontalAvailableSpace < m_line.contentLogicalWidth(); > > + if (!lineHasOverflowAfterTrimmingTrailingContent || isInIntrinsicWidthMode) > > Maybe this function should be refactored a bit, for example split into > before-trimming and after-trimming parts? It is kinda confusing there is a > lineHasOverflow variable in the scope that has incorrect value. yeah I agree, it should be scoped.
Created attachment 463262 [details] Patch
Created attachment 463264 [details] Patch
Committed 256045@main (fc54f33c5cd4): <https://commits.webkit.org/256045@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463264 [details].
<rdar://problem/101616260>
*** Bug 248877 has been marked as a duplicate of this bug. ***