RESOLVED FIXED 24705
Can't set location.href in chromium 
https://bugs.webkit.org/show_bug.cgi?id=24705
Summary Can't set location.href in chromium
Dave Moore
Reported 2009-03-19 16:26:52 PDT
A bug in the V8 bindings is preventing chromium from setting the href on the location object...any attempt throws a security error, not just for javascript protocols. See chromium bug http://code.google.com/p/chromium/issues/detail?id=8603
Attachments
Patch (1.20 KB, patch)
2009-03-19 16:30 PDT, Dave Moore 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Moore
Comment 1 2009-03-19 16:30:28 PDT
Created attachment 28770 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2009-03-20 09:17:08 PDT
Dave, can we possibly prefix this with V8, so that it's clear that this is a V8-specific modification. Also, I want to make sure Sam is ok with this. Adding him to cc.
Dave Moore
Comment 3 2009-03-20 09:26:13 PDT
I had it that way at one point, but Mike felt that it was better to do it without #ifdef'ing it
Sam Weinig
Comment 4 2009-03-20 12:44:12 PDT
Seems fine to me. The CustomSetter clearly overrides this for JSC.
Dimitri Glazkov (Google)
Comment 5 2009-03-20 14:28:09 PDT
Gah. I didn't realize I wasn't on cc list.
David Levin
Comment 6 2009-03-20 16:00:00 PDT
Assigned to levin for landing.
David Levin
Comment 7 2009-03-20 16:57:51 PDT
Committed as r41882.
Note You need to log in before you can comment on or make changes to this bug.