WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
247034
[git-webkit] Deeply inspect potential gardening commits
https://bugs.webkit.org/show_bug.cgi?id=247034
Summary
[git-webkit] Deeply inspect potential gardening commits
Jonathan Bedard
Reported
2022-10-25 17:18:09 PDT
Gardening commits should not be considered "pickable." While we're pretty good at identifying commits as gardening commits, many of the strings used can also be used in legitimate commit messages. If we inspect the files changed in a commit, however, gardening commits become obvious. We can't performantly check all commits on a branch, but we can inspect every potential gardening commit.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-10-25 17:18:25 PDT
<
rdar://problem/101568509
>
Jonathan Bedard
Comment 2
2022-10-25 17:19:44 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/5789
EWS
Comment 3
2022-10-26 08:09:38 PDT
Committed
256014@main
(28f6affda692): <
https://commits.webkit.org/256014@main
> Reviewed commits have been landed. Closing PR #5789 and removing active labels.
EWS
Comment 4
2022-10-26 08:55:10 PDT
Committed
252432.685@safari-7614-branch
(d93ba4173c65): <
https://commits.webkit.org/252432.685@safari-7614-branch
> Reviewed commits have been landed. Closing PR #162 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug