RESOLVED FIXED 246957
[build.webkit.org] BuildAndTestAllButJSCFactory must forward parameters correctly to BuildAndTestFactory 
https://bugs.webkit.org/show_bug.cgi?id=246957
Summary [build.webkit.org] BuildAndTestAllButJSCFactory must forward parameters corre...
Lauro Moura
Reported 2022-10-24 12:57:15 PDT
The initial version of https://github.com/WebKit/WebKit/pull/5710 added `additionalArguments` to a bunch of bots, including GTK-Linux-64-bit-Release-GTK4-Tests, which uses the BuildAndTestAllButJSCFactory, a subclass of BuildAndTestFactory. This raised a failure in the build-webkit-org unittests with the extra steps when `triggers` is non-null added to the test output. Turns out that BuildAndTestAllButJSCFactory wasn't forwarding the `triggers` parameter correctly to its parent class. Originally `additionalArguments` was empty, and the test worked fine. Patch incoming.
Attachments
Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2022-10-24 19:42:27 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5729
EWS
Comment 2 2022-10-25 06:43:38 PDT
Committed 255956@main (bb74e4622540): <https://commits.webkit.org/255956@main> Reviewed commits have been landed. Closing PR #5729 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-10-25 06:44:18 PDT
<rdar://problem/101543208>
Note You need to log in before you can comment on or make changes to this bug.