Bug 246904 - AX: Simplify AXObjectCache by making better use of AXIsolatedTree::treeForPageID(std::optional<PageIdentifier>)
Summary: AX: Simplify AXObjectCache by making better use of AXIsolatedTree::treeForPag...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-22 11:51 PDT by Tyler Wilcock
Modified: 2022-10-22 20:51 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.20 KB, patch)
2022-10-22 11:54 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-10-22 11:51:58 PDT 
Several places in AXObjectCache manually check that m_pageID is not std::nullopt rather than using the existing AXIsolatedTree::treeForPageID(std::optional<PageIdentifier>) method.
Comment 1 Radar WebKit Bug Importer 2022-10-22 11:52:10 PDT 
<rdar://problem/101462585>
Comment 2 Tyler Wilcock 2022-10-22 11:54:36 PDT 
Created attachment 463168 [details]
Patch
Comment 3 EWS 2022-10-22 20:51:11 PDT 
Committed 255891@main (ff6a48ca8eab): <https://commits.webkit.org/255891@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463168 [details].