Bug 246883 - Clamp fullscreen window size based on video dimensions
Summary: Clamp fullscreen window size based on video dimensions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-21 13:45 PDT by Dean Jackson
Modified: 2022-10-21 16:15 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2022-10-21 13:45:00 PDT 
We have a preferred size for fullscreen windows, and then we try to fit video into that size. But if the video is an unusual aspect ratio, we can accidentally create windows that escape the bounds.
Comment 1 Radar WebKit Bug Importer 2022-10-21 13:45:22 PDT 
<rdar://problem/101439923>
Comment 2 Dean Jackson 2022-10-21 13:50:47 PDT 
https://github.com/WebKit/WebKit/pull/5647
Comment 3 EWS 2022-10-21 16:15:16 PDT 
Committed 255857@main (1626a43b85c9): <https://commits.webkit.org/255857@main>

Reviewed commits have been landed. Closing PR #5647 and removing active labels.