Bug 246881 - [css-typed-om] Use `std::optional<CSSNumberish>&&` instead of `std::optional<CSSNumberish>`
Summary: [css-typed-om] Use `std::optional<CSSNumberish>&&` instead of `std::optional<...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks: 175733
  Show dependency tree / graph
 
Reported: 2022-10-21 13:16 PDT by Antoine Quint
Modified: 2022-10-21 22:40 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-10-21 13:16:46 PDT 
I got such review feedback during https://github.com/WebKit/WebKit/pull/5641 and it turns out CSSScale::create() had the same problem.
Comment 1 Antoine Quint 2022-10-21 13:18:44 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5644
Comment 2 EWS 2022-10-21 22:26:10 PDT 
Committed 255864@main (24da58ad6fed): <https://commits.webkit.org/255864@main>

Reviewed commits have been landed. Closing PR #5644 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-10-21 22:27:18 PDT 
<rdar://problem/101453650>