RESOLVED FIXED 246856
Factorize common platform code for font feature variant 
https://bugs.webkit.org/show_bug.cgi?id=246856
Summary Factorize common platform code for font feature variant
Matthieu Dubet
Reported 2022-10-21 07:09:36 PDT
Some lengthy code (computeFeatureSettingsFromVariants ~300 lines) is exactly the same in Harfbuzz and GTK, we should factorize it. https://github.com/WebKit/WebKit/blob/main/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp#L181 https://github.com/WebKit/WebKit/blob/main/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp#L84
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-10-21 07:10:05 PDT
<rdar://problem/101426315>
Matthieu Dubet
Comment 2 2022-10-21 07:16:17 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5631
EWS
Comment 3 2022-10-21 12:19:09 PDT
Committed 255842@main (5535cabfe075): <https://commits.webkit.org/255842@main> Reviewed commits have been landed. Closing PR #5631 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.