RESOLVED FIXED 24685
Use Skia integer primitives for drawing Chromium Linux scrollbars 
https://bugs.webkit.org/show_bug.cgi?id=24685
Summary Use Skia integer primitives for drawing Chromium Linux scrollbars
Adam Langley
Reported 2009-03-18 16:54:00 PDT
The Skia drawLine function takes subpixel values and attempts to draw a line with subpixel precision. This is complex and slow for drawing scrollbars which use only vertical and horizontal lines. This changes the Chromium Linux scrollbar code to use drawIRect. Layout test changes will be in the Chromium tree.
Attachments
patch (6.88 KB, patch)
2009-03-18 16:55 PDT, Adam Langley 		fishd: review-
DetailsFormatted DiffDiff
patch (7.13 KB, patch)
2009-03-24 16:37 PDT, Adam Langley 		fishd: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Langley
Comment 1 2009-03-18 16:55:00 PDT
Created attachment 28737 [details] patch
Darin Fisher (:fishd, Google)
Comment 2 2009-03-23 11:40:21 PDT
Comment on attachment 28737 [details] patch > +static void drawVertLine(SkCanvas* canvas, int x, int y1, int y2, const SkPaint& paint) { > + SkIRect skrect; > + skrect.set(x, y1, x + 1, y2 + 1); > + canvas->drawIRect(skrect, paint); > +} nit: please use webkit style (4 space indent, bracket on newline). there are a lot of these style violations in this patch as well as in the previous file. please fix :)
Adam Langley
Comment 3 2009-03-24 16:37:15 PDT
Created attachment 28917 [details] patch
Darin Fisher (:fishd, Google)
Comment 4 2009-03-24 17:03:10 PDT
Landed as: http://trac.webkit.org/changeset/41960
Note You need to log in before you can comment on or make changes to this bug.