Bug 246841 - [WebXR] Catch undeleted GL objects with OwnedGLObject
Summary: [WebXR] Catch undeleted GL objects with OwnedGLObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebXR (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dan Glastonbury
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-20 19:41 PDT by Dan Glastonbury
Modified: 2022-10-23 16:56 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Glastonbury 2022-10-20 19:41:14 PDT 
Use OwnedGLObject to ensure that OpenGL objects are correctly released
to avoid leaks. OwnedGLObject provides a reset/release interface similar
to std::unique_ptr. The results of reset() and release() are marked
[[nodiscard]] to signal the old value must be correctly handled. In
addition, release() must be called to disarm OwnedGLObject destructor
ASSERT.
Comment 1 Radar WebKit Bug Importer 2022-10-20 19:41:28 PDT 
<rdar://problem/101410305>
Comment 2 EWS 2022-10-23 16:56:23 PDT 
Committed 255900@main (0a69bc3f00f0): <https://commits.webkit.org/255900@main>

Reviewed commits have been landed. Closing PR #5616 and removing active labels.