Bug 246753 - WebGL compilation disabling WebGL 2 is broken
Summary: WebGL compilation disabling WebGL 2 is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alejandro G. Castro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-19 11:17 PDT by Alejandro G. Castro
Modified: 2022-10-20 13:41 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2022-10-19 11:17:25 PDT 
WebGLVertexArrayObject is part of the WebGL 2 API but there are some places in the code where it was added under the WEBGL ifdef instead of WEBGL2
Comment 1 Alejandro G. Castro 2022-10-19 11:25:46 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5544
Comment 2 EWS 2022-10-20 01:23:37 PDT 
Committed 255778@main (6b4ed06fa609): <https://commits.webkit.org/255778@main>

Reviewed commits have been landed. Closing PR #5544 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-10-20 01:24:20 PDT 
<rdar://problem/101371285>
Comment 4 Fujii Hironori 2022-10-20 13:27:54 PDT 
Does GTK port still need ENABLE_WEBGL2 macro?
Why don't you just remove all ENABLE_WEBGL2 macro?
IIUC, there is no port disabling ENABLE_WEBGL2 if ENABLE_WEBGL is on.
Comment 5 Alejandro G. Castro 2022-10-20 13:41:16 PDT 
Apparently we are still doing it for some images we are generating for rpi devices, it would be great to do that if we don't find problems with devices that do not support opengles3.