Bug 246747 - [macOS] Fix absolute paths to macOS libraries in WebKit
Summary: [macOS] Fix absolute paths to macOS libraries in WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-19 09:33 PDT by Elliott Williams
Modified: 2022-10-19 12:52 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-10-19 09:33:30 PDT 
WebKit shouldn't be linking against libraries on the host system, it should always be using paths relative to the current SDKROOT. These dylib references need to be fixed:

https://github.com/WebKit/WebKit/blame/4fdd802cd89f9f7ecfb664cf9436f498bd7a4f51/Source/WebKit/Configurations/WebKit.xcconfig#L56 https://github.com/WebKit/WebKit/blame/4fdd802cd89f9f7ecfb664cf9436f498bd7a4f51/Source/WebKit/Configurations/WebKit.xcconfig#L167
Comment 1 Elliott Williams 2022-10-19 09:34:51 PDT 
<rdar://problem/101228686>
Comment 2 Elliott Williams 2022-10-19 09:35:08 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5539
Comment 3 EWS 2022-10-19 12:52:29 PDT 
Committed 255751@main (de70c68258f5): <https://commits.webkit.org/255751@main>

Reviewed commits have been landed. Closing PR #5539 and removing active labels.