Bug 246746 - [WTF] MediaTime: compute flags on multiplication with doubles
Summary: [WTF] MediaTime: compute flags on multiplication with doubles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-19 08:50 PDT by Alicia Boya García
Modified: 2022-10-19 16:28 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2022-10-19 08:50:50 PDT 
[WTF] MediaTime: compute flags on multiplication with doubles
value without updating the flags. This becomes a problem if the
multiplication promotes the number to infinity.
Comment 1 Alicia Boya García 2022-10-19 09:22:10 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5538
Comment 2 Alicia Boya García 2022-10-19 09:28:01 PDT 
Fixed description:

The current multiplication algorithm in WTF::MediaTime updates the time
value without updating the flags. This becomes a problem if the
multiplication promotes the number to infinity.
Comment 3 EWS 2022-10-19 16:27:11 PDT 
Committed 255767@main (c020c7e213d8): <https://commits.webkit.org/255767@main>

Reviewed commits have been landed. Closing PR #5538 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2022-10-19 16:28:20 PDT 
<rdar://problem/101358049>