Bug 246718 - [Xcode] Race condition when generating IDLFileNamesList.txt
Summary: [Xcode] Race condition when generating IDLFileNamesList.txt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-18 15:51 PDT by Elliott Williams
Modified: 2022-10-18 18:44 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-10-18 15:51:00 PDT 
WebCore's DerivedSources.make generates this file once per invocation of preprocess-idls.pl:

    $(IDL_INTERMEDIATE_PATTERNS) : …
    	$(shell echo $(JS_BINDING_IDLS) | tr " " "\n" > IDLFileNamesList.txt)
    	$(PERL) $(WebCore)/bindings/scripts/preprocess-idls.pl …

This can cause race conditions where proprocess-idls.pl is reading the list while another thread is regenerating it. We only need to generate it once, so this can be fixed by generating the list as a separate step.
Comment 1 Elliott Williams 2022-10-18 15:57:52 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5516
Comment 2 EWS 2022-10-18 18:43:41 PDT 
Committed 255709@main (244ca6a14f4a): <https://commits.webkit.org/255709@main>

Reviewed commits have been landed. Closing PR #5516 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-10-18 18:44:24 PDT 
<rdar://problem/101319105>