RESOLVED FIXED 246713
[GTK] -Wunused-function warnings when building with GTK 4 
https://bugs.webkit.org/show_bug.cgi?id=246713
Summary [GTK] -Wunused-function warnings when building with GTK 4
Michael Catanzaro
Reported 2022-10-18 14:44:27 PDT
This is a follow-up to bug #244892: [58/230] Building CXX object Tools/TestWebKitAPI/glib/CMa...TestDownloads.dir/__/Tests/WebKitGLib/TestDownloads.cpp.o /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:831:13: warning: ‘void testContextMenuDownloadActions(WebViewDownloadTest*, gconstpointer)’ defined but not used [-Wunused-function] 831 | static void testContextMenuDownloadActions(WebViewDownloadTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [61/230] Building CXX object Tools/TestWebKitAPI/glib/CMa...stOptionMenu.dir/__/Tests/WebKitGLib/TestOptionMenu.cpp.o /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp:269:13: warning: ‘void testOptionMenuSelect(OptionMenuTest*, gconstpointer)’ defined but not used [-Wunused-function] 269 | static void testOptionMenuSelect(OptionMenuTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp:239:13: warning: ‘void testOptionMenuActivate(OptionMenuTest*, gconstpointer)’ defined but not used [-Wunused-function] 239 | static void testOptionMenuActivate(OptionMenuTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp:158:13: warning: ‘void testOptionMenuGroups(OptionMenuTest*, gconstpointer)’ defined but not used [-Wunused-function] 158 | static void testOptionMenuGroups(OptionMenuTest* test, gconstpointer) | ^~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp:116:13: warning: ‘void testOptionMenuSimple(OptionMenuTest*, gconstpointer)’ defined but not used [-Wunused-function] 116 | static void testOptionMenuSimple(OptionMenuTest* test, gconstpointer)
Attachments
Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2022-10-18 15:49:44 PDT
Created bug #246716 to fix the signal so that we can reenable the tests.
Michael Catanzaro
Comment 2 2022-10-19 12:08:28 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5548
EWS
Comment 3 2022-10-19 14:58:29 PDT
Committed 255760@main (40b5b869cece): <https://commits.webkit.org/255760@main> Reviewed commits have been landed. Closing PR #5548 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.