media/video-object-fit.html Is a constant image failure on iOS ToT and since 255635@main. The image diff suggests an image tolerance issue. This could be a possible progression also if looking at 255635@main. HISTORY: https://results.webkit.org/?suite=layout-tests&test=media/video-object-fit.html DIFF: 0.21% image difference. *Diff images attached*
<rdar://problem/101298592>
Created attachment 463061 [details] Diff images
This issue can be bisected to 255635@main using command: run-webkit-tests --iterations=2 --ios-simulator media/video-object-fit.html
Test gardening commit 255684@main (16142a75bab4): <https://commits.webkit.org/255684@main> Reviewed commits have been landed. Closing PR #5502 and removing active labels.
This went from failing in one way to failing another.
This may get better via https://commits.webkit.org/256069@main.
(In reply to Jer Noble from comment #6) > This may get better via https://commits.webkit.org/256069@main. And it does appear that this test is passing now: Test run @ 10/27/2022, 10:49:30 AM Commits: 256071@main iOS 16 Simulator wk2 Release on iPad (5th generation) with x86_64 (20A360) Expected: IMAGE Actual: PASS
I spoke too soon; looks like it was a flaky pass.
(In reply to Jer Noble from comment #8) > I spoke too soon; looks like it was a flaky pass. Aaaand, it looks like a spoke too soon about speaking too soon. The new failure mode is that all the images match (and correctly implement `object-fit:` values). But the test now generates a `FAIL` string at the end, which is surprising, since there are no failure modes in the test itself.
Pull request: https://github.com/WebKit/WebKit/pull/5982
Committed 256320@main (5c28999a8939): <https://commits.webkit.org/256320@main> Reviewed commits have been landed. Closing PR #5982 and removing active labels.