Bug 246681 - Add function to copy the state of a GraphicsContext to another GraphicsContext
Summary: Add function to copy the state of a GraphicsContext to another GraphicsContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 198416
  Show dependency tree / graph
 
Reported: 2022-10-18 01:35 PDT by Said Abou-Hallawa
Modified: 2022-10-19 10:12 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2022-10-18 01:35:43 PDT 
Changes in GraphicsContextState are tracked by an OptionSet. GraphicsContextState::mergeChanges() relies on this OptionSet to copy the changes from GraphicsContextState to another. This should work correctly if the two GraphicsContexts are synced all the times. But what we need for the canvas filter API is to copy the current GraphicsContextState of a canvas context to a newly created ImageBuffer.
Comment 1 Radar WebKit Bug Importer 2022-10-18 01:41:27 PDT 
<rdar://problem/101282195>
Comment 2 Said Abou-Hallawa 2022-10-18 01:42:15 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5485
Comment 3 EWS 2022-10-19 10:12:07 PDT 
Committed 255741@main (f3147a407737): <https://commits.webkit.org/255741@main>

Reviewed commits have been landed. Closing PR #5485 and removing active labels.