Bug 246638 – [leading-trim] Add support for parsing "leading-trim" CSS property

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[zalan]

Created attachment 463035 [details]
Patch

[zalan]

no tests yet.

[Tim Nguyen (:ntim)]

Comment on attachment 463035 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463035&action=review

> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:250
> +    unsigned leadingTrim : 3; // LeadingTrim

This fits in 2

[Tim Nguyen (:ntim)]

(Also, does this need a `settings-flag` field in CSSProperties.json and an associated preference?)

[Antti Koivisto]

Comment on attachment 463035 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463035&action=review

> Source/WebCore/css/CSSProperties.json:2959
> +        "leading-trim": {
> +            "values": [
> +                "normal",
> +                "start",
> +                "end",
> +                "both"
> +            ],
> +            "specification": {
> +                "category": "css-inline",
> +                "url": "https://www.w3.org/TR/css-inline-3/#leading-trim"
> +            }
> +        },

This should probably have a setting which can be given using "settings-flag" codegen option.

[Antti Koivisto]

Comment on attachment 463035 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463035&action=review

>> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:250
>> +    unsigned leadingTrim : 3; // LeadingTrim
> 
> This fits in 2

You should initialise this field.

It also needs to be present in the copy constructor and operator==.

[Antti Koivisto]

Comment on attachment 463035 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463035&action=review

> Source/WebCore/css/CSSPrimitiveValueMappings.h:1089
> +template<> inline CSSPrimitiveValue::CSSPrimitiveValue(LeadingTrim e)

"e"

> Source/WebCore/css/CSSPrimitiveValueMappings.h:1106
> +        break;
> +    }

Could ASSERT_NOT_REACHED here

[Radar WebKit Bug Importer]

<rdar://problem/101504835>

[zalan]

Created attachment 463745 [details]
Patch

[zalan]

Created attachment 463748 [details]
Patch

[zalan]

Created attachment 463760 [details]
[fast-cq]Patch

[EWS]

Committed 257070@main (8fe0bbfa84f9): <https://commits.webkit.org/257070@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463760 [details].