WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
246595
Change CSSValue types to have immutable value semantics
https://bugs.webkit.org/show_bug.cgi?id=246595
Summary
Change CSSValue types to have immutable value semantics
Sam Weinig
Reported
2022-10-16 13:04:50 PDT
To create a clear boundary and allow for more caching opportunities, we should convert the CSSValue types to have immutable value semantics, moving whatever remains to the style / style building system. In the end, I would like to have a type for each possible top level css value, and make CSSValue itself a type-erasing wrapper of sorts: struct CSSValue { std::variant< // Each css value type here. > value; }; We can use this opportunity to create more strongly typed results coming out of the parser, so style building does not have to do quite as much type checking or assuming.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-10-23 13:05:18 PDT
<
rdar://problem/101479589
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug