Bug 24657 - Chromium fails SVG image-small-width-height layout test
Summary: Chromium fails SVG image-small-width-height layout test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Glen Murphy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-17 16:13 PDT by Glen Murphy
Modified: 2009-03-23 11:54 PDT (History)
1 user (show)

See Also:


Attachments
ImageSkia.cpp change (1.47 KB, patch)
2009-03-17 16:16 PDT, Glen Murphy
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Glen Murphy 2009-03-17 16:13:30 PDT
Skia fails to render the SVG image-small-width-height layout test correctly because we perform an unnecessary IntRect conversion when calling paintSkBitmap in ImageSkia.cpp.
Comment 1 Glen Murphy 2009-03-17 16:16:31 PDT
Created attachment 28707 [details]
ImageSkia.cpp change

Updates ImageSkia.cpp to stop the unnecessary conversion to IntRect in our calls to paintSkBitmap.
Comment 2 Darin Fisher (:fishd, Google) 2009-03-23 11:35:15 PDT
Looks good to me, but I'm not expert on this code.  It would be good to get a "LGTM" from Brett.
Comment 3 Darin Fisher (:fishd, Google) 2009-03-23 11:44:49 PDT
Comment on attachment 28707 [details]
ImageSkia.cpp change

Brett gave verbal LGTM.  r=me

Next time, please be sure to include a link to this bug in the ChangeLog entry.  Thanks!
Comment 4 Darin Fisher (:fishd, Google) 2009-03-23 11:54:46 PDT
Landed as:  http://trac.webkit.org/changeset/41913