RESOLVED FIXED246561
[WGSL] Prefix AST files to avoid name clashes 
https://bugs.webkit.org/show_bug.cgi?id=246561
Summary [WGSL] Prefix AST files to avoid name clashes
Dan Glastonbury
Reported 2022-10-14 21:33:13 PDT
WebKit projects are built in Xcode using header maps, so each header file needs a unique name. WebGPU project has two headers named `ShaderModule.h`. Since paths aren't used to disambiguate headers, I propose prefixing all WGSL AST node headers with `AST` and removing the nested directory structure.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-10-14 21:33:52 PDT
<rdar://problem/101198489>
Dan Glastonbury
Comment 2 2022-10-15 22:53:46 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5426
EWS
Comment 3 2022-10-17 00:17:09 PDT
Committed 255614@main (2b6ef0c64240): <https://commits.webkit.org/255614@main> Reviewed commits have been landed. Closing PR #5426 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.