Bug 24651 - Skia does not always render text fill/stroke pattern/gradient/color correctly
Summary: Skia does not always render text fill/stroke pattern/gradient/color correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-17 13:12 PDT by Scott Violet
Modified: 2009-03-17 15:17 PDT (History)
1 user (show)

See Also:

Attachments
Fix for 24651 (6.41 KB, patch)
2009-03-17 13:17 PDT, Scott Violet 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Violet 2009-03-17 13:12:56 PDT 
Skia's text rendering gives preference to the gradient, then the pattern. This is problematic though in that once a gradient has been set the gradient getter always returns non-null. Skia needs to only use the gradient/pattern if the fill/strokecolorspace indicates the gradients/pattern should be used.

This can be seen when using the test case LayoutTests/fast/canvas/canvas-text-alignment.html.
Comment 1 Scott Violet 2009-03-17 13:17:23 PDT 
Created attachment 28697 [details]
Fix for 24651
Comment 2 Eric Seidel (no email) 2009-03-17 14:06:36 PDT 
Comment on attachment 28697 [details]
Fix for 24651

OK.
Comment 3 Eric Seidel (no email) 2009-03-17 15:17:45 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/GraphicsContext.cpp
	M	WebCore/platform/graphics/GraphicsContext.h
	M	WebCore/platform/graphics/GraphicsContextPrivate.h
	M	WebCore/platform/graphics/skia/SkiaFontWin.cpp
Committed r41789