Bug 246501 - [GTK][a11y] /WebKitGTK/TestWebKitAccessibility:/webkit/WebKitAccessibility/accessible/children-changed is failing
Summary: [GTK][a11y] /WebKitGTK/TestWebKitAccessibility:/webkit/WebKitAccessibility/ac...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-13 20:24 PDT by Lauro Moura
Modified: 2023-12-01 08:01 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2022-10-13 20:24:08 PDT
/WebKitGTK/TestWebKitAccessibility /webkit/WebKitAccessibility/accessible/children-changed

This exact failure is not always happening due to the SDK issue from bug246471, so I had to completely ignore fatal warnings to get to these.

EWS history shows this has been failing in a while (couldn't pick up where yet).

Notes from investigation:

  * The test creates a `div` with two `p` - `foo` and `bar` - which are the accessible objects. Working fine.
  * Then the test creates a new `p`, called `baz`, working fine.
  * Then the test removes `foo`, working fine.
  * Then the test changes the role - through JS - of `bar` and checks whether the existing object had its role changed without detach+attach
    * This test fails, with the existing object still having the role `paragraph`
    * If I get the children at the same position again, it already has the right `button` role
  * Also, in line: https://github.com/webkit/webkit/blob/main/Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp#L388
    * if we replace the `test->stopEventTimer(0, 0.5_s)` with an actual timer, two events are fired:
    * `object:children-changed:remove` with `detail1 == 1`
    * `object:children-changed:add` with `detail1 == 0`
Comment 1 Radar WebKit Bug Importer 2022-10-13 20:24:19 PDT
<rdar://problem/101156751>
Comment 2 Vitaly Dyackhov 2023-12-01 04:27:06 PST
Pull request: https://github.com/WebKit/WebKit/pull/21155
Comment 3 EWS 2023-12-01 08:01:20 PST
Committed 271382@main (e32c6f904bc6): <https://commits.webkit.org/271382@main>

Reviewed commits have been landed. Closing PR #21155 and removing active labels.