Bug 246487 - Refactor RegisterSet to support 128-bit widths
Summary: Refactor RegisterSet to support 128-bit widths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-13 16:33 PDT by Justin Michaud
Modified: 2022-12-12 10:39 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Michaud 2022-10-13 16:33:06 PDT 
Refactor RegisterSet to support 128-bit widths
Comment 1 Radar WebKit Bug Importer 2022-10-13 16:33:24 PDT 
<rdar://problem/101148986>
Comment 2 Justin Michaud 2022-10-13 16:43:39 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5354
Comment 3 EWS 2022-10-15 10:14:07 PDT 
Committed 255583@main (a57d810b085e): <https://commits.webkit.org/255583@main>

Reviewed commits have been landed. Closing PR #5354 and removing active labels.
Comment 4 Alexey Proskuryakov 2022-10-16 18:36:56 PDT 
This was reverted in bug 246588 / 255596@main because of build breakage.
Comment 5 EWS 2022-10-19 08:54:17 PDT 
Committed 255736@main (912bf24408b1): <https://commits.webkit.org/255736@main>

Reviewed commits have been landed. Closing PR #5522 and removing active labels.
Comment 6 Michael Catanzaro 2022-10-19 12:20:41 PDT 
This introduced a minor GCC warning spam, one warning for each unified source bundle that includes the header:

[783/2475] Building CXX object Source/JavaScriptCore/CMak...vedSources/unified-sources/UnifiedSource-15db4ad9-4.cpp.o
In file included from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmFormat.h:39,
                 from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmCallee.h:33,
                 from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmCalleeGroup.h:31,
                 from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmModule.h:30,
                 from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmModule.cpp:27,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk4/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-4.cpp:2:
/home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk4/JavaScriptCore/DerivedSources/WasmOps.h: In member function ‘JSC::Width JSC::Wasm::Type::width() const’:
/home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk4/JavaScriptCore/DerivedSources/WasmOps.h:122:5: warning: control reaches end of non-void function [-Wreturn-type]
  122 |     }

I will submit a follow-up.
Comment 7 Justin Michaud 2022-10-19 12:58:30 PDT 
Oops, sorry!
Comment 8 Michael Catanzaro 2022-10-19 13:52:45 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/5555
Comment 9 EWS 2022-10-19 16:00:14 PDT 
Committed 255764@main (7bb3ebc2f29b): <https://commits.webkit.org/255764@main>

Reviewed commits have been landed. Closing PR #5555 and removing active labels.
Comment 10 EWS 2022-12-12 10:39:44 PST 
Committed 257737@main (2d2f8ac6371b): <https://commits.webkit.org/257737@main>

Reviewed commits have been landed. Closing PR #7487 and removing active labels.