RESOLVED FIXED246478
Commit URLs causing 500 Internal Server Error 
https://bugs.webkit.org/show_bug.cgi?id=246478
Summary Commit URLs causing 500 Internal Server Error
lingho@apple.com
Reported 2022-10-13 15:50:46 PDT
When a commit range URL in the form of "https://commits.webkit.org/compare/123456@main<ellipsis>234567@main" is entered into a comment, saving the comment, or subsequence comments causes bug page to return 500 Internal Server Error.
Attachments
Add attachment proposed patch, testcase, etc.
lingho@apple.com
Comment 1 2022-10-13 15:51:16 PDT
rdar://98541419
lingho@apple.com
Comment 2 2022-10-13 16:02:54 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5349
lingho@apple.com
Comment 3 2022-10-13 16:06:54 PDT
The old regex was matching the 2nd commit ID, causing that part to be replaced with a URL, which in turn causing the 500 error. The new regex should not match /123456@main and …123456@main and thus leave them alone.
lingho@apple.com
Comment 4 2022-10-13 17:56:08 PDT
Updated title to cover another issue reported by Fujihori https://webkit.slack.com/archives/CU64U6FDW/p1664478835893709 where url such as this https://commits.webkit.org/ + 252432.352@safari-7614-branch is causing issue.
EWS
Comment 5 2022-10-14 17:05:45 PDT
Committed 255564@main (f59283656141): <https://commits.webkit.org/255564@main> Reviewed commits have been landed. Closing PR #5349 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.