WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
24647
Add a new header file available to WebCore, WebKit and tools for configuration options
https://bugs.webkit.org/show_bug.cgi?id=24647
Summary
Add a new header file available to WebCore, WebKit and tools for configurati...
Simon Fraser (smfr)
Reported
2009-03-17 10:14:07 PDT
From
bug 24396
:
> > +#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) > > +#define WTF_USE_ACCELERATED_COMPOSITING 0 > > +#endif > > I'm worried about this. Why do we have to set this up both in config.h and in > the prefix? This should be in exactly one place. It's OK to have that one place > be included both by the prefix and config.h, but it's not OK to repeat things > like this. I know this configuration stuff is a mess, but I would like to keep > it from getting even worse. Maybe there's nothing you can easily improve here. > We could talk about this in person at some point if you like.
Agreed. I asked Mark Rowe about this and he didn't have any suggestions. We need a header that is included by all code in WebCore, WebKit and tools (DRT), and gets preprocessed after the platform defines.
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug