RESOLVED FIXED 24645
bisect-builds script doesn't work with Safari 4 Public Beta (version string) 
https://bugs.webkit.org/show_bug.cgi?id=24645
Summary bisect-builds script doesn't work with Safari 4 Public Beta (version string)
David Kilzer (:ddkilzer)
Reported 2009-03-17 09:04:59 PDT
* SUMMARY The bisect-build script doesn't work with the Safari 4 Public Beta installed because the version string isn't parseable by Perl. * NOTES I have a quick fix, but it's suboptimal.
Attachments
Patch v1 (2.25 KB, patch)
2009-03-17 11:19 PDT, David Kilzer (:ddkilzer) 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2009-03-17 11:19:38 PDT
Created attachment 28693 [details] Patch v1 This fixes bisect-builds with Safari 4 Public Beta. The long-term fix is to switch from using "CFBundleShortVersionString" to using "CFBundleVersion" in findSafariVersion().
David Kilzer (:ddkilzer)
Comment 2 2009-03-17 13:14:41 PDT
$ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bisect-builds Committed r41785 http://trac.webkit.org/changeset/41785
David Kilzer (:ddkilzer)
Comment 3 2009-03-17 13:16:18 PDT
(In reply to comment #1) > The long-term fix is to switch from using "CFBundleShortVersionString" to using > "CFBundleVersion" in findSafariVersion(). See Bug 24652.
Note You need to log in before you can comment on or make changes to this bug.