Bug 24645 - bisect-builds script doesn't work with Safari 4 Public Beta (version string)
Summary: bisect-builds script doesn't work with Safari 4 Public Beta (version string)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-17 09:04 PDT by David Kilzer (:ddkilzer)
Modified: 2009-03-17 13:16 PDT (History)
3 users (show)

See Also:


Attachments
Patch v1 (2.25 KB, patch)
2009-03-17 11:19 PDT, David Kilzer (:ddkilzer)
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2009-03-17 09:04:59 PDT
* SUMMARY
The bisect-build script doesn't work with the Safari 4 Public Beta installed because the version string isn't parseable by Perl.

* NOTES
I have a quick fix, but it's suboptimal.
Comment 1 David Kilzer (:ddkilzer) 2009-03-17 11:19:38 PDT
Created attachment 28693 [details]
Patch v1

This fixes bisect-builds with Safari 4 Public Beta.

The long-term fix is to switch from using "CFBundleShortVersionString" to using "CFBundleVersion" in findSafariVersion().
Comment 2 David Kilzer (:ddkilzer) 2009-03-17 13:14:41 PDT
$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/bisect-builds
Committed r41785

http://trac.webkit.org/changeset/41785
Comment 3 David Kilzer (:ddkilzer) 2009-03-17 13:16:18 PDT
(In reply to comment #1)
> The long-term fix is to switch from using "CFBundleShortVersionString" to using
> "CFBundleVersion" in findSafariVersion().

See Bug 24652.