Bug 24642 – REGRESSION: Nightly builds sometimes erroneously display a message about failing to launch successfully

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

* SUMMARY
When launching WebKit nightly r41707, an error dialog is displayed about WebKit not being able to launch.  Hitting the "Continue" button, though launches Safari with the gold icon anyway, but NOT using the nightly libraries (which is even more confusing).

[David Kilzer (:ddkilzer)]

Created attachment 28686 [details]
Warning dialog

[David Kilzer (:ddkilzer)]

This appears to be an issue with only the Launcher as the bisect-builds works just fine with nightly build r41760.

[David Kilzer (:ddkilzer)]

Happens as far back as r39682 (which is the first nightly build that works with Safari 4 Public Beta).  Can't really test before that.

[Mark Rowe (bdash)]

That is not a surprise, given that this part of the launcher code has not changed in a very long time.

[Mark Rowe (bdash)]

It seems unlikely that this is specific to Tiger as well.

[Mark Rowe (bdash)]

*** Bug 24774 has been marked as a duplicate of this bug. ***

[Mark Rowe (bdash)]

*** Bug 24773 has been marked as a duplicate of this bug. ***

[CWG]

Still seeing this in r42075, just downloaded.

This in OS X 10.4.11.

[CWG]

Still seeing this in r42260.

[CWG]

Still seeing this in r2583.  Been a month.  Are we ever again going to see a Webkit that will launch?

[CWG]

Correction: *in r42583*

[David Kilzer (:ddkilzer)]

Mark, we fixed this by using a "defaults delete" command.  Do you recall which key it was?  It must have been in org.webkit.nightly.WebKit somewhere.

CWG: What does "defaults read org.webkit.nightly.WebKit" print for you from Terminal?

[CWG]

David:

CWs-MBP:~ cw$ defaults read org.webkit.nightly.WebKit
{
    ApplicationCrashedAfterRelaunch = 0; 
    SUEnableAutomaticChecks = 1; 
    SUHasLaunchedBefore = 1; 
    SULastCheckTime = 2009-03-20 01:28:48 -0700; 
    SUSendProfileInfo = 0; 
    StartPageShownInVersion = 42583; 
}

[David Kilzer (:ddkilzer)]

(In reply to comment #13)
> David:
> 
> CWs-MBP:~ cw$ defaults read org.webkit.nightly.WebKit
> {
>     ApplicationCrashedAfterRelaunch = 0; 
>     SUEnableAutomaticChecks = 1; 
>     SUHasLaunchedBefore = 1; 
>     SULastCheckTime = 2009-03-20 01:28:48 -0700; 
>     SUSendProfileInfo = 0; 
>     StartPageShownInVersion = 42583; 
> }

I think it's safe simply to delete all of the org.webkit.nightly.WebKit settings, since that will put you back to a state before you ever launched a WebKit nightly build.

$ defaults delete org.webkit.nightly.WebKit

What happened is that one of the flags gets set when you launched the bad build, but doesn't get reset when launching future good builds.  Deleting all the settings for org.webkit.nightly.WebKit simply wipes the slate clean and lets you continue using the good builds again.

[Mark Rowe (bdash)]

(In reply to comment #14)
> What happened is that one of the flags gets set when you launched the bad
> build, but doesn't get reset when launching future good builds.  Deleting all
> the settings for org.webkit.nightly.WebKit simply wipes the slate clean and
> lets you continue using the good builds again.

The relevant settings are actually stored in the com.apple.Safari preference domain.  It uses the keys WKNERunState and WKNEShouldMonitorShutdowns.

[CWG]

David:

> 
> $ defaults delete org.webkit.nightly.WebKit
> 

Thanks for the attempt, but that didn't do it.  Even repeated and with a fresh Webkit dragged in, still got the:

WebKit failed to open correctly on your previous attempt. Please disable any Safari extensions that you may have installed.  If the problem continues to occur, please file a bug report at http://webkit.org/quality/reporting.html

"Continue" dialog on launch.

Defaults now read:

CWs-MBP:~ cw$ defaults read org.webkit.nightly.WebKit
{StartPageShownInVersion = 42583; }

Thanks again,

[CWG]

Mark:

> 
> The relevant settings are actually stored in the com.apple.Safari preference
> domain.  It uses the keys WKNERunState and WKNEShouldMonitorShutdowns.
> 

    WKNERunState = 1; 

Could not find any:

    WKNEShouldMonitorShutdowns

Can I change that RunState, without defaulting the rest of my Safari prefs?  If so, how, and to what?

Thanks,

[Mark Rowe (bdash)]

Fixed in r44524.  There'll be a new nightly up soon.

[CWG]

So I noted, last download.

Thank you very much.

CW

[CWG]

It's been a long time, without WebKit.