Bug 246391 - Fix WKContentRuleListStore API tests after 255298@main
Summary: Fix WKContentRuleListStore API tests after 255298@main
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
: 246286 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-10-11 22:59 PDT by Alex Christensen
Modified: 2022-10-12 15:34 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2022-10-11 22:59:22 PDT 
That change didn't get serialization quite right.  ModifyHeadersAction::serializedLength should've returned deserializeLength(span, sizeof(uint32_t)) + sizeof(uint32_t) but to make that serializedLength more consistent with the other serializedLength methods I just make the serialization start with the total serialized length.  Also fix a possible out-of-bounds read.
Comment 1 Alex Christensen 2022-10-11 22:59:57 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5279
Comment 2 EWS 2022-10-11 23:10:36 PDT 
Committed 255419@main (bdd355ff73a9): <https://commits.webkit.org/255419@main>

Reviewed commits have been landed. Closing PR #5279 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-10-11 23:11:19 PDT 
<rdar://problem/101066138>
Comment 4 Alexey Proskuryakov 2022-10-12 15:34:51 PDT 
*** Bug 246286 has been marked as a duplicate of this bug. ***