WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
246391
Fix WKContentRuleListStore API tests after
255298@main
https://bugs.webkit.org/show_bug.cgi?id=246391
Summary
Fix WKContentRuleListStore API tests after 255298@main
Alex Christensen
Reported
2022-10-11 22:59:22 PDT
That change didn't get serialization quite right. ModifyHeadersAction::serializedLength should've returned deserializeLength(span, sizeof(uint32_t)) + sizeof(uint32_t) but to make that serializedLength more consistent with the other serializedLength methods I just make the serialization start with the total serialized length. Also fix a possible out-of-bounds read.
Attachments
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2022-10-11 22:59:57 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/5279
EWS
Comment 2
2022-10-11 23:10:36 PDT
Committed
255419@main
(bdd355ff73a9): <
https://commits.webkit.org/255419@main
> Reviewed commits have been landed. Closing PR #5279 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2022-10-11 23:11:19 PDT
<
rdar://problem/101066138
>
Alexey Proskuryakov
Comment 4
2022-10-12 15:34:51 PDT
***
Bug 246286
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug